yuzutech / kroki

Creates diagrams from textual descriptions!
https://kroki.io
MIT License
2.87k stars 211 forks source link

Kroki 0.17.1: PlantUML and DomainStory #1272

Closed anb0s closed 2 years ago

anb0s commented 2 years ago

After update own instance to Kroki 0.17.1 i'm trying DomainStory as standard include:

@startuml
!include <DomainStory/domainStory>
Boundary(System) {
    Person(Alice)
    Conversation(weather)
    Person(Bob)
}
activity(1, Alice, talks about the, weather, with, Bob)
@enduml

It works in VSCode if http://www.plantuml.com/plantuml is used as server: image

@ official PlantUML server

@ our Kroki shows image

I cannot test with official Kroki instance as it is not yet updated

Any hints how to proceed?

P.S.: It looks like there is also special handling for C4 diagrams in Kroki, do we need also something to support new PlantUML stdlibs ? How other stdlibs (Azure etc.) that are working with standard include are handled?

anb0s commented 2 years ago

handled in this array

ggrossetie commented 2 years ago

Nice catch! Feel free to add DomainStory to the list and update this test: https://github.com/yuzutech/kroki/blob/a209cdf566ed0a02007e9436f9223eaf4bc79b57/server/src/test/java/io/kroki/server/service/PlantumlServiceTest.java#L171-L187

anb0s commented 2 years ago

@Mogztter thank you!

anb0s commented 2 years ago

@Mogztter we are waiting for DomainStory and i've to ask when the new release will be published?

ggrossetie commented 2 years ago

Not sure, probably in the next few days depending on how much time I can allocate 😉

ggrossetie commented 2 years ago

It's live! 🎉

image