search

yuzutech / kroki

Creates diagrams from textual descriptions!
https://kroki.io
MIT License
2.83k stars 209 forks source link

Support the proprietary TALA layout engine for d2 #1628

Open vfosnar opened 11 months ago

vfosnar commented 11 months ago

Support the TALA layout engine.

This would require mounting a volume for the license key to be automatically renewable.

ggrossetie commented 11 months ago

This is mostly a documentation issue to explain how to support it? I guess the right way is to extend the base image and install the proprietary layout engine.

vfosnar commented 11 months ago

I think a better way is to always install it. Then, depending on configuration, allow users to use it or not.

ggrossetie commented 11 months ago

I think a better way is to always install it

I don't think we are allow to do that according to the Terms and Conditions of Terrastruct:

Customer shall not (and shall not permit others to): (i) license, sub-license, sell, transfer, distribute or share the Services or Software or make any of them available for access by third parties; (...)

https://terrastruct.com/terms-and-conditions/

@alixander Would you be kind enough to provide us with a clear answer regarding what is allowed or not from a licensing perspective? Thanks!

vfosnar commented 11 months ago

This should be okay if it isn't enabled on the public instance, as it isn't distributing anything (except for the bundled binary).

We'll see