yuzutech / kroki

Creates diagrams from textual descriptions!
https://kroki.io
MIT License
2.78k stars 206 forks source link

Kroki integration in GitLab not rendering in Chrome #809

Closed vioan closed 3 years ago

vioan commented 3 years ago

I have Kroki setup as a self hosted service and integrated with GitLab.

I added some diagrams in a few markdown files and they are rendered in Firefox/Safari but it seems that Chrome/Edge is just showing a placeholder (small icon) for the images/diagrams. The image/diagram is available via Kroki instance, as I can right click on placeholder and is opened in browser on Kroki server.

Any idea what can be? Is that a GitLab UI/rendering issue or is something related to Kroki?

Thank you very much.

vioan commented 3 years ago

ok, I found the issue. Chrome by default doesn’t allow/embed “http” images in sites with “https”.

temp fix:

permanent fix:

ggrossetie commented 3 years ago

Thanks for the follow-up. Might be worth to explain how to do it in the documentation but let's continue the discussion here: https://github.com/yuzutech/kroki/issues/787