search

yuzutech / kroki

Creates diagrams from textual descriptions!
https://kroki.io
MIT License
2.79k stars 206 forks source link

Include additional PlantUML themes #900

Closed ggrossetie closed 2 years ago

ggrossetie commented 2 years ago

PlantUML provides a list of built-in themes.

https://github.com/Drakemor/RedDress-PlantUML and https://github.com/isaaceindhoven/plantuml-styler both provide PlantUML themes that are quite nice but not (yet) included in PlantUML.

Upstream issue: https://github.com/plantuml/plantuml/issues/667

Gray tone graytone

Isaac isaac

Deep sea deepsea

Black and white blackwhite

Dark blue DARKBLUE

Light blue LIGHTBLUE

Dark red DARKRED

LIGHTRED

LIGHTRED

Dark green DARKGREEN

Light green LIGHTGREEN

Dark orange DARKORANGE

Light orange LIGHTORANGE

ggrossetie commented 2 years ago

RedDress themes have been added upstream and are available in PlantUML v1.2021.12. isaaceindhoven/plantuml-styler cannot be included upstream because this library does actually not use skinparam commands but update the SVG DOM: https://github.com/isaaceindhoven/plantuml-styler/blob/05d01f6a79967c0b4bb99336fb19da2c66766dfa/src/app/services/generate.service.ts#L127-L188

ggrossetie commented 2 years ago

Resolved in https://github.com/yuzutech/kroki/commit/4e58e4d5044855c33cf8079db9fb72c73cc98501

Names: