search

yves-vogl / aws-eks-helm-deploy

Bitbucket Pipe for deploying Helm Charts to AWS Elastic Kubernetes Service
Other
8 stars 15 forks source link

Add helm timeout configurable #15

Closed Babbleshack closed 5 months ago

Babbleshack commented 5 months ago

Adds timeout configurable

closes #14

Babbleshack commented 5 months ago

@yves-vogl are there any other changes you might need before this can be merged?

yves-vogl commented 5 months ago

Thank you for your work! As you maybe can see I’ve not much time to review and merge changes. I’ll try to get back to this soon.

But as we are talking - are you interested in being a maintainer for this repo?

Regards Yves

Babbleshack commented 5 months ago

Sure that can work. How do we go forward with this?

-------- Original Message -------- On 29/05/2024 21:11, Yves Vogl wrote:

Thank you for your work! As you maybe can see I’ve not much time to review and merge changes. I’ll try to get back to this soon.

But as we are talking - are you interested in being a maintainer for this repo?

Regards Yves

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

yves-vogl commented 5 months ago

Let me review the pending issue tommorrow, do some housekeeping. After that I'll add you as maintainer and share contact information with you so that we can team up.Would this work for you?Thank you so far - I really appreciate this!On 29. May 2024, at 22:14, Dominic Lindsay @.***> wrote: Sure that can work. How do we go forward with this?

-------- Original Message -------- On 29/05/2024 21:11, Yves Vogl wrote:

Thank you for your work! As you maybe can see I’ve not much time to review and merge changes. I’ll try to get back to this soon.

But as we are talking - are you interested in being a maintainer for this repo?

Regards Yves

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Babbleshack commented 5 months ago

Yer that works. I use this for work so I have a good reason to maintain it.

No problem. Thanks for the opportunity.

yves-vogl commented 5 months ago

I've merged your PR. I'll now do some housekeeping (we've holidays in NRW, Germany today). After that I'll get in touch with you so that we can find a way to communicate.

Thank you - teamwork is simply the best <3

Babbleshack commented 5 months ago

Awesome! I saw you pushed a new release to docker hub too. Thank you!

Enjoy your holiday, ill catch up with you when you return.

yves-vogl commented 5 months ago

You're welcome :-)

Releasing to dockerhub ist automated. I added you in LinkedIn by the way. And set you up as collab on Bitbucket. If you tell me your DockerHub name, I'll add you there as well.

Babbleshack commented 5 months ago

My dockerhub username is babbleshack too.