yvesf / andiodine

Android VPN over DNS (no root required). Repo moved to gitlab
https://gitlab.com/andiodine/andiodine
150 stars 27 forks source link

add multicast lock #28

Closed jovial closed 7 years ago

jovial commented 7 years ago

Not sure if this is needed when using UDP in native code. Thoughts?

yvesf commented 7 years ago

For me it's not clear why it should be required. DNS UDP Packets are not multicast. It will probably not harm but I would like to have a good reason to do it.

jovial commented 7 years ago

Yeah, I think you are right. It was the first thing I tried when I hit that dns detection bug and I was just blindly copying a UDP example. I will close this, as like you say, It doesn't seem to be necessary,