search

yvoronoy / magento2-bash-completion

Magento2 Bash Completion
MIT License
140 stars 29 forks source link

Update README.md #13

Closed Zifius closed 7 years ago

Zifius commented 7 years ago

Removed sudo as bash_completion.d folder is owned by current user

yvoronoy commented 7 years ago

@Zifius Alexander, thank you for contribution 👍

Zifius commented 7 years ago

Cheers @yvoronoy. Looking forward to zsh support :)

yvoronoy commented 7 years ago

@Zifius actually I don't use ZSH, but I've found some solution on StackOverflow and looks like it has to be working under ZSH without additional changes. Could you check if it works for you? http://stackoverflow.com/questions/3249432/i-have-a-bash-tab-completion-script-is-there-a-simple-way-to-use-it-from-zsh

if so, probably we have to update README

Zifius commented 7 years ago

@yvoronoy it indeed works but slowdowns initial prompt significantly, also throws errors:

_magento2:4: command not found: get_comp_words_by_reg
_magento2:98: command not found: __ltrim_colon_completions

So native implementation would be beneficial, e.g. as part of https://github.com/zsh-users/zsh-completions, anyway zsh completion is much better in terms of explaining which command does what. I'll try to find time to implement

By the way I needed #12 to be able to autocomplete with php bin/magento or bin/magento

yvoronoy commented 7 years ago

@Zifius I see, thank you for checking. It would be really cool if you find time to implement it.

It's weird why it doesn't work with relative paths? On my OSX and Linux works as expected. But probably I have to add it since few people complain about it.

Thank you