Ghosts stuck in temple on payday

[GoogleCodeExporter]

During the last game I played, my ghosts kept getting stuck in the temple. 
Played on r1430, on this map:
https://keeperklan.com/threads/4831-My-very-1st-maps-by-UM21

To reproduce load the save, and wait for payday(speed up the game). At that 
moment you will see all the ghosts in the temple move to the bottom tile and 
stay there indefinitely thinking about gold.

Original issue reported on code.google.com by Loobinex on 26 Oct 2014 at 1:54

Attachments:

• stuckghost.zip

[GoogleCodeExporter]

Can you find the first revision which introduced the problem?

Original comment by mefistotelis on 26 Oct 2014 at 7:54

• Changed state: Accepted

[GoogleCodeExporter]

Sure,...

r1385 and after -> Can reproduce the issue
r1382 and before -> Can't reproduce the issue

In r1384 you changed the way flying creatures change altitude, so my guess is 
this is where it breaks.

Original comment by Loobinex on 26 Oct 2014 at 10:20

[GoogleCodeExporter]

Thank you.

The ghosts were stuck in the ceiling - because temple floor is higher, there's 
less space before ceiling.

I made a fix - hopefully will get rid of such issues for good.

But this is curious - ghosts have a height of 2 tiles (512), like most humanoid 
standing creatures. Maybe this should be altered - looking at ghosts 
appearance, I wouldn't tell he's as tall as Barbarian or Archer.

Dragons look taller and their height does correspond to that.

Original comment by mefistotelis on 26 Oct 2014 at 6:31

[GoogleCodeExporter]

I agree. Their eye-height should be around the same height as normal humanoids, 
but as they are flying. So if they fly about a tile high, the ghost itself 
should also be about a tile high.
Visually this seems to match, the look a bit taller than say a demon spawn, but 
not as big as a bile demon.

My vote goes to 256.

Original comment by Loobinex on 26 Oct 2014 at 7:57

[GoogleCodeExporter]

I now had a ghost stuck in a hallway on payday,... r1434. See attached save.

Did not happen all the time though, so unfortunately no savegame from before 
the fact.

Played on the second map of this campaign:
https://keeperklan.com/threads/4791-Preview-of-my-custom-Campaign-The-Barbarian-
Campaign

Original comment by Loobinex on 28 Oct 2014 at 12:11

Attachments:

• 406v2.zip

[GoogleCodeExporter]

This last one was caused by something completely different - error in room 
code. Fixed.

Original comment by mefistotelis on 28 Oct 2014 at 5:19

[GoogleCodeExporter]

I've noticed that ThingSize is same for all creatures - they only differ in 
sprite image size. For now let's leave the sizes - it'd have to be tested 
whether differentiating the sizes has any benefits.

This concludes the issue - ghost problems are fixed.

Original comment by mefistotelis on 1 Nov 2014 at 12:17

• Changed state: Fixed
• Added labels: Component-Creatures

[GoogleCodeExporter]

What about the eye-height?

Original comment by Loobinex on 2 Nov 2014 at 12:28