yvt / openspades

Compatible client of Ace of Spades 0.75
http://openspades.yvt.jp/
GNU General Public License v3.0
1.12k stars 218 forks source link

Flathub lists this project as proprietary? #1095

Open RustoMCSpit opened 4 months ago

RustoMCSpit commented 4 months ago

https://flathub.org/apps/jp.yvt.OpenSpades

"Proprietary This app is not developed in the open, so only its developers know how it works. It may be insecure in ways that are hard to detect, and it may change without oversight."

maybe this is correct, i am not sure if this is just an open source client of the proprietary ace of spades or if it is a totally independent clone based off of it that is entirely open source. your two pages contradict each other

the website says

What is OpenSpades?

OpenSpades is a clone of Ace of Spades 0.75,

the github says

Compatible client of Ace of Spades 0.75

mschlumpp commented 3 months ago

There is one resource pack that contains some non GPL files. I don't remember how important that file was, but the flatpak tries to reflect that in the metadata. However, the proprietary part might be consider more important in the "App Store" GUIs.

So the code is GPL but some resources (which you could replace in theory) are not. At least that's the perspective of me who helped with the packaging a bit.

samknaup commented 3 months ago

See #424, someone's already made a replacement pack https://github.com/DeathByDenim/openspades-free-pak but it hasn't been merged in.

RustoMCSpit commented 3 months ago

See #424, someone's already made a replacement pack https://github.com/DeathByDenim/openspades-free-pak but it hasn't been merged in.

why not