search

yvt / openspades

Compatible client of Ace of Spades 0.75
http://openspades.yvt.jp/
GNU General Public License v3.0
1.13k stars 218 forks source link

Compilation fails on aarch64 #906

Open parkerlreed opened 4 years ago

parkerlreed commented 4 years ago

Possibly related to #416. New issue because different architecture and the only solution back then was a fork which is now outdated

Log https://gist.github.com/parkerlreed/5ee2e088851036eb8f500bfb7c8a3011

parkerlreed commented 4 years ago

As suggested on that issue, I tried adding stk's Angelscript arm snippet to the current openspades but it still bails trying the x64 codepath.

https://github.com/supertuxkart/stk-code/blob/master/lib/angelscript/projects/cmake/CMakeLists.txt#L115

Haxk20 commented 3 years ago

Yes this is because OpenSpades uses a VERY old version of AngelScript. 2.31.1 which is from 2016 and the latest is 2.33 from 2018 which includes many fixes for the aarch64.

I will fork OS today and see if i can update the AngelScript version to the latest version.

EDIT: So it seems like yvt and other people did some changes to the AngelScript and updating it is not just copy and paste. Also updating it would require some changes in the addons because it changed a little and addons fail.

@yvt Updating the angelscript from https://sourceforge.net/p/angelscript/code/commit_browser to r2666 would fix most of our issues and OS would be able to run on aarch64.

Haxk20 commented 3 years ago

BTW this is how supertuxkart got it fixed https://github.com/supertuxkart/stk-code/issues/2569

CloudyProton commented 3 years ago

The same issue occurs when building on ppc64el 

/usr/bin/ld: ../lib/libAngelscript.a(as_callfunc.cpp.o): in function CallSystemFunction(int, asCContext*)':
/home/User/OpenSpades/openspades/Sources/AngelScript/source/as_callfunc.cpp:712: undefined reference to CallSystemFunctionNative(asCContext*, asCScriptFunction*, void*, unsigned int*, void*, unsigned long&, void*)'
collect2: error: ld returned 1 exit status
make[2]: *** [Sources/CMakeFiles/OpenSpades.dir/build.make:3562: bin/openspades] Error 1
make[1]: *** [CMakeFiles/Makefile2:230: Sources/CMakeFiles/OpenSpades.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
yvt commented 2 years ago

Removing the bug label as it's not a bug but just a lack of support.

tigercoding56 commented 1 year ago

any activity on solving this issue ?

also you can compile with #1005 but it will not start