Replace Thread.isAlive() with Thread.is_alive()

ywangd / stash

StaSh - Shell for Pythonista

MIT License

1.94k stars 227 forks source link

Replace Thread.isAlive() with Thread.is_alive() #473

Closed cclauss closed 1 year ago

cclauss commented 1 year ago

Thread.is_alive() was added in Python 2.6 so we can change .isAlive() to .is_alive() everywhere to be compatible with all versions of Pythonista.

https://docs.python.org/2/library/threading.html#threading.Thread.is_alive
https://github.com/ywangd/stash/pull/463#discussion_r1126007645

cclauss commented 1 year ago

@mkb79 @bennr01 @jsbain Your reviews, please.

cclauss commented 1 year ago

Yes. I am trying to break #463 into bite-sized chunks so we can get it all merged.

cclauss commented 1 year ago

@bennr01 Migrated to dev

cclauss commented 1 year ago

Closing in favor of #478