Replace Thread.isAlive() with Thread.is_alive() AGAIN

ywangd / stash

StaSh - Shell for Pythonista

MIT License

1.94k stars 227 forks source link

Replace Thread.isAlive() with Thread.is_alive() AGAIN #478

Closed cclauss closed 1 year ago

cclauss commented 1 year ago

Thread.is_alive() was added in Python 2.6 so we can change .isAlive() to .is_alive() everywhere to be compatible with all versions of Pythonista.

https://docs.python.org/2/library/threading.html#threading.Thread.is_alive
https://github.com/ywangd/stash/pull/463#discussion_r1126007645

cclauss commented 1 year ago

@bennr01 Your review, please.

bennr01 commented 1 year ago

Great, thank you for the pull request.