search

ywangd / stash

StaSh - Shell for Pythonista
MIT License
1.92k stars 227 forks source link

Error on launch stash on pythonista PY:3.10 #491

Closed Filza2 closed 1 year ago

Filza2 commented 1 year ago

_properties = plistlib.readPlist(os.path.join(os.path.dirname(sys.executable), 'Info.plist'))

AttributeError: module 'plistlib' has no attribute 'readPlist'

and there is another problem, in _render Timer has no attribute isAlive()

- I don’t know if there is another problems but stash need update

jwinnenb commented 1 year ago

This is fixed in PR #485

You can replace

_properties = plistlib.readPlist(os.path.join(os.path.dirname(sys.executable), 'Info.plist'))

With:

_properties = plistlib.load(open(os.path.join(os.path.dirname(sys.executable), 'Info.plist'), 'rb'))

To clear the first error.

Then replace isAlive with is_alive to get around the second problem.

Both are deprecated functions that had been removed from their respective libraries.

Fun thing is, once I fixed those two problems, stash will start but I'm getting a keyboard error every other line and a problem with urlparse (Another 2.7 to 3.10 issue).

cclauss commented 1 year ago

Fixed in #485 (merged)