yxli2123 / LoftQ

MIT License
180 stars 15 forks source link

Number of iterations seems always set to 1 based on latest code #34

Open au-revoir opened 5 days ago

au-revoir commented 5 days ago

Hi, it looks like after the PEFT integration, the iter argument is not being used. I don't see any for loop for alternate quantization and low-rank approximation. There seems to be only a single execution here https://github.com/huggingface/peft/blob/09358aad308604f7a132cf94709bcc9399a2e1ab/src/peft/utils/loftq_utils.py#L390

Can you verify if this is the case?