search

yxymit / banshee

6 stars 7 forks source link

Timing Records #2

Open bakhshalipour opened 6 years ago

bakhshalipour commented 6 years ago

Hi,

First, I appreciate for kindly releasing the codes. I have a question regarding the changes have been made in _ddrmem.cpp file. In DDRMemory::access function, based on the type of requests, some TimingRecords have been considered for them. Are they necessary for getting correct results? Can we get rid of assertions by safely removing them, while maintaining the correctness?

Thanks

yxymit commented 6 years ago

Hi,

Different type of requests should use different configurations of TimingRecords. The parameters indicate the timing of the current request w.r.t. other requests, e.g., do they happen in series or parallel.

Since the assertions do not fail, you can get rid them safely. They are there for debugging purposes.

Best