search

yy1lab / Lyrics-Conditioned-Neural-Melody-Generation

423 stars 59 forks source link

Normalized key, tempi? #1

Open xhevahir opened 5 years ago

xhevahir commented 5 years ago

The Neural Melody Composition from Lyrics paper recommends setting every midi file to the same tempo and key. Would it help to do this with your data? (Or maybe they're the same already? Your paper doesn't say.)

yy1lab commented 5 years ago

During the parsing, we take the tempo of the MIDI song into account to calculate the duration of the note with the actual length of the note in seconds. The formula is : note.duration = note.length * tempo / 60 and we then constrain it to the closest existing note to obtain a usable duration value.

xhevahir notifications@github.com 于2019年8月30日周五 上午4:50写道：

The Neural Melody Composition from Lyrics paper recommends setting every midi file to the same tempo and key. Would it help to do this with your data? (Or maybe they're the same already? Your paper doesn't say.)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yy1lab/Lyrics-Conditioned-Neural-Melody-Generation/issues/1?email_source=notifications&email_token=AMQGHTAKP32TH2CHLXLBC6DQHASBHA5CNFSM4ISGGPEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIJH7DQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQGHTEJX6NXXD53C4K7B3LQHASBHANCNFSM4ISGGPEA .

xhevahir commented 5 years ago

Is the tonality/key/key signature handled in some way? I haven't been able to find out.

yy1lab commented 5 years ago

The data is not set to the same key. The duration's unit is the beat. Therefore, the absolute duration of a note or a rest is depending on the tempo. However, this is not used during training or sampling. Can you please keep the question open ? thus, people can read the answers when they have this kind of question.

xhevahir notifications@github.com 于2019年8月31日周六 上午3:16写道：

Is the tonality/key/key signature handled in some way? I haven't been able to find out.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/yy1lab/Lyrics-Conditioned-Neural-Melody-Generation/issues/1?email_source=notifications&email_token=AMQGHTEZEHFBODJW7ST7X3DQHFPY7A5CNFSM4ISGGPEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SMUEY#issuecomment-526699027, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQGHTDJCCLQNPEE2IG4SGTQHFPY7ANCNFSM4ISGGPEA .