yyccbb / pe

0 stars 0 forks source link

DG wrong multiplicity for drug allergy #17

Open yyccbb opened 6 months ago

yyccbb commented 6 months ago

image.png This is what the DG shows. However, since drug allergy can be null, the multiplicity should not be 1.

image.png This is another piece of evidence.

soc-se-bot commented 6 months ago

Team's Response

We appreciate the effort in looking through the codebase to check whether the UML matches with the implementation. Though from the screenshot it may seem that DrugAllergy can be null, but in the parser itself in the code base it creates a default DrugAllergy object that contains the value "No Allergy" which is still not a null object in implementation perspective. Here is the evidence from the codebase:

image.png

It is understood that a more defensive coding approach can be done within the Person class to also include null checks for the drug allergy field. This can definitely be done with gender as well. But in the current implementation, the parser ensures that a default DrugAllergy is made nonetheless and would not be of null value in the Person Object. But, we decided to still make this NotInScope as such defensive implementation enhancements can be made in the next release for the Person Class.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]