yyccbb / pe

0 stars 0 forks source link

The in-app error message for NRIC constraint violation has spelling problem #5

Open yyccbb opened 7 months ago

yyccbb commented 7 months ago

image.png The word "Nric" spelled in this way might lead to ambiguity. Should be "NRIC".

soc-pe-bot commented 7 months ago

Team's Response

From the message itself it should still imply the same meaning which is still referring to NRIC regardless of the case and can still be considered trivial. Though, it can be converted to UPPERCASE for future releases and can be seen as a very minor enhancement NotInScope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: image.png Personally, I think a commercialized product would not have 'NRIC' written this way because 'nric' is not an English word. I hence regard this as a typo which should have been fixed during the feature freeze.