Modifications to... - Githubissues

yydcdut / RxMarkdown

:fax:Markdown for Android, supports TextView && EditText (Live Preview), supports code high light.

749 stars 92 forks source link

Modifications to... #7

Closed bjdupuis closed 7 years ago

bjdupuis commented 8 years ago

Better identify inappropriate italics and bold (e.g. in file names, with incorrect whitespace usage).
Quote relative size, colored backgrounds, and custom colored backgrounds depending on nesting level.
Code uses a monospace typeface.

bjdupuis commented 8 years ago

Preview of the colored blockquote backgrounds and custom background depending on nesting level. screen shot 2016-10-27 at 5 37 50 pm

Brief preview of some of the emphasis parsing that wasn't handled correctly in some cases previously. screen shot 2016-10-27 at 5 39 01 pm

And the monospace font for code/pre sections. screen shot 2016-10-27 at 5 40 42 pm

yydcdut commented 8 years ago

hi, these days i'm busy with company's project.Today, I read the code, thank you anyway! I see you close this pl, so need I merge? the changes are good ideas for me and for this project!

bjdupuis commented 7 years ago

Hi. I closed it for a couple of reasons:

I didn't modify the edit version, just the view version.
I'd planned to make modifications to the build system that the Travis CI weren't happy with and didn't want to break your CI setup or your build. That's why I closed it when I did.

You are certainly welcome to the actual changes if you want them included! You may wish to revert the gradle changes, though.