DeskNotifier code refactoring

yyfearth / madtalk

MadTalk - IM with Markdown

http://madtalk.yyfearth.com/

MIT License

1 stars 0 forks source link

Closed masonwan closed 12 years ago

masonwan commented 12 years ago

I tried to make the code more elegant and decided to use getter and setter.

The problems are

After a little research, it seems that Microsoft consider definedGetter as legacy and use Object.defineProperty Function in JS 1.8.5.

masonwan commented 12 years ago

Successfully Implemented defineProperty and add getters
Potential bug: if notifications are too many, the querying notification won't fire close event.

yyfearth commented 12 years ago

i modified the code to test the coffeescript function param feature, if u do not like it just recover yours.

yyfearth commented 12 years ago

close this and move to #29