yyolk / xrpl-price-persist-oracle

A Serverless Application Model stack that persists the $XRP price to the XRPL every minute as a TrustLine. There are no servers, it is effectively a "smart contract" in Python for the XRPL.
https://egge.gg
Other
9 stars 2 forks source link

semicolon over comma #2

Closed yyolk closed 3 years ago

yyolk commented 3 years ago

match csv delimiter of semicolon.

i think this makes sense if an aggregate of currencies where some use commas like the EUR ( € 10 € 10,10 € 10 000,10)

another wise decision from Wietse

https://www.quora.com/How-do-you-write-sums-of-euros-over-1-000-i-e-where-do-you-put-the-full-stops-and-the-commas

this also has the added benefit of matching the serialization of the XUMM oracle.

yyolk commented 3 years ago

LGTM image https://testnet.xrpl.org/transactions/572DFBFCB9D2A812F6724A6BF97E41F66E7BCBE8BEC16B857CC6DAFACBFB8569/detailed