search

yyr / wrf_install

Download & build process of wrf model with all dependencies
GNU General Public License v3.0
36 stars 23 forks source link

fix error in zsh environment #11

Closed qingu closed 9 years ago

qingu commented 9 years ago

When I 'source SOURCEME' in zsh environment, Zsh doesn't recoginze variable BASH_SOURCE. So I write some judgment statements to fix it. Hope you can accept this pull request.

yyr commented 9 years ago

Hello,

Thanks for the pull. please check the comments.

qingu commented 9 years ago

Thanks for your quick reply. The statement of "if [ -z "$ZSH_NAME" ] && [ "x$0" = "x./SOURCEME" ]; " let the user know whether he/she is sourcing properly or not. And I have deleted the comments in the script. Sorry, I don't know github well. Do I need to pull request again?

yyr commented 9 years ago

Sorry, I don't know github well. Do I need to pull request again?

you don't need request a pull again. just push new commits to the same branch (in this case your develop branch). They will be updated here.

yyr commented 9 years ago

Also please push your changes to github. I can take care later on.

qingu commented 9 years ago

The change has been commited to github. You can check it.

yyr commented 9 years ago

I now cherry picked your commit to master without merge commit from this pull. Thanks for pull again.

By the way I see now, your master is diverged from my repo's master because of your merge commit. You may want to fix that.