Add filtering based on train mission names

[Egglestron]

Description

Add filtering based on mission names (JourneyNote).

Use case

Some trains with the same terminus number don't stop at my station and are thus irrelevant. Moreover, the number of trains can be overwhelming (more than 10 per hour) and this can help filter some of those.

Example

VOLA, POPI, PASA, etc.

[yyrkoon94]

Hi @Egglestron,

Thanks for this first PR and happy to have a new contributor 😄

I understand your need, but from what I see in the code, it's only for RER lines. So perhaps we should be more precise in the wording of the option, something like “Exclure les missions de lignes RER (ex: VOPA, POPA, PASA)”. Another point: for excluding lines, I added a button to display the line number to help populate the parameter. In your case, I have no help finding the “mission” of the RER, right? If not, we need to add something to help find it.

What do you think ?

[wgrs33]

We could add few filters: one is by checking the vehicle name as @Egglestron proposed, other might be for final destination name. It could be something like:

- filter:
    train: ["VOPA", "POPA", ...]
    destination: ["Saint-Cloud", "Paris Montparnasse", ...]

[Egglestron]

Hi @Egglestron,

Thanks for this first PR and happy to have a new contributor 😄

I understand your need, but from what I see in the code, it's only for RER lines. So perhaps we should be more precise in the wording of the option, something like “Exclure les missions de lignes RER (ex: VOPA, POPA, PASA)”. Another point: for excluding lines, I added a button to display the line number to help populate the parameter. In your case, I have no help finding the “mission” of the RER, right? If not, we need to add something to help find it.

What do you think ?

Hi and thanks for the warm welcome! I agree that we should have more precise wording, I'm not a communte expert so feel free to modify my pull request! 😆 However regarding the user help, unless there is a misunderstanding, it's not needed as it's displayed by default:

We could add few filters: one is by checking the vehicle name as @Egglestron proposed, other might be for final destination name. It could be something like:

- filter:
    train: ["VOPA", "POPA", ...]
    destination: ["Saint-Cloud", "Paris Montparnasse", ...]

It could be cool to have a more generic filtering YAML scheme. However in your example, the destination name is redundant with the terminus/destination "reference number" already implemented, right?

[wgrs33]

Hi @Egglestron,

Not really. Reference number will filter out other lines when you send the request to the server but it won't filter the destination/terminus which you're not interested in.

Example Having a train L and its stop in Saint-Cloud you'll have at least 3 destinations available: Paris Saint-Lazar, Versailles and Saint-Nom-la-Breteche. If you only want to display the one which goes to Paris its tricky, because the reference number is attached to the line, not to the route is has.

[yyrkoon94]

Hi @wgrs33, @Egglestron,

What do we do with this PR ? We take it as a first filtering implementation ? (I would like a create a new release soon ;))