yyx990803 / laravel-vue-cli-3

Example project using Vue CLI 3 with Laravel
848 stars 183 forks source link

Add support for Nova routes #9

Closed lamalamaMark closed 4 years ago

NSpehler commented 6 years ago

May I suggest you use this regex instead? This allows for third-party Nova packages as well:


Route::any('{all}', function(){
    return view('app');
})->where('all', '^(?![nova-api][nova-vendor]).*$');
NSpehler commented 6 years ago

It looks like my above regex is not working. Use this instead:


Route::any('{all}', function(){
    return view('app');
})->where('all', '^(?!((nova-api)|(nova-vendor))).*$');
M-Porter commented 6 years ago

Why are you suggesting changes to an application for a paid piece of software? Seems strange considering this project is showcasing vue-cli-3 with laravel not nova with laravel.

DataMarq commented 6 years ago

The above regex route definition isn't working with newest version of Laravel Nova. It was working with 1.0.6 but not just upgraded to newest 1.0.13 and it stopped working.