fix: use escape instead of allow list when launching through Windows cmd

yyx990803 / launch-editor

Open file in editor from Node.js.

MIT License

585 stars 67 forks source link

fix: use escape instead of allow list when launching through Windows cmd #78

Closed haoqunjiang closed 2 months ago

haoqunjiang commented 2 months ago

Fixes #35 Fixes #76 Closes #54 Closes #57 Fixes #74#issuecomment-2269583713

haoqunjiang commented 2 months ago

@dominikg @btea I finally got the time to research the cumbersome and fragmented cmd documentation online and came up with this solution. Could you help review it?

dominikg commented 2 months ago

approving based on documentation available, havn't tested it on an acutal windows machine due to lack thereof