yyyaohhh / pe

0 stars 0 forks source link

Sort age command does not work according to UG #4

Open yyyaohhh opened 11 months ago

yyyaohhh commented 11 months ago

After executing the sort age command, it shows me a success message that the list is sorted.

image.png

But the two people named John Doe should rank before Charlotte because they are born in 1990, and Charlotte is 1989. the sorting is wrong.

image.png

nus-pe-bot commented 11 months ago

Team's Response

Thanks for bringing this up! We understand the confusion, but there is no mistake in the sorting as the age in our product is calculated based on the present date i.e. even though both John Does are born in 1990 and Charlotte in 1989, they are the same age since Charlotte's birthday has not passed. This is in line with how most countries calculate age.

We acknowledge that it might be helpful to calculate the age more precisely (taking into account the days and months), but we believe that this enhancement can be made in a future iteration, and that our current implementation is sufficient for now. :)

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: > the age in our product is calculated based on the present date i.e. even though both John Does are born in 1990 and Charlotte in 1989, they are the same age since Charlotte's birthday has not passed.

I understand that this feature can be further improved on, but unfortunately, this was not mentioned in the User Guide or the Developer Guide at all. Furthermore, since Charlotte's birthday is later than John's, she is definitely days older than Johns. And I believe most users would find it weird and abnormal seeing a "1989" popping out in between rows of "1990"s.

I believe that the team has sorted according to the patient's age in years, then sorted patients with the same age in alphabetical order. Thus this should be considered a rather significant functionality bug because they did not mention this sorting pattern at all, and most users would assume that the age is accurately calculated and ranked, at least in the precision of months.