search

yyyaohhh / pe

0 stars 0 forks source link

wrong error message #6

Open yyyaohhh opened 1 year ago

yyyaohhh commented 1 year ago

error message shows: Unable to edit department of a patient, even though the IC and department provided are in the correct format. but actually should show that the patient does not exist, because i did not add the patient yet image.png

nus-pe-script commented 1 year ago

Team's Response

Thanks for pointing this out! I understand where you are coming from, however when there are multiple errors in a command, only 1 of it can be shown first. For our implementation, we choose to prioritise checking the error of having wrong fields (i.e. d/DEPARTMENT should not be a parameter in the edit command) over the checking of whether patient is present, after all, only when command input is correct then can we then check for the duplicate patients.

On the error of wrong fields and having a wrong error message for that, we did mention under the planned enhancements in the developers guide as well. https://ay2324s1-cs2103t-t14-2.github.io/tp/DeveloperGuide.html#appendix-planned-enhancements

image.png

As such, we will reject this bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]