search

yyyaohhh / pe

0 stars 0 forks source link

Code does not match with the description. #9

Open yyyaohhh opened 1 year ago

yyyaohhh commented 1 year ago

Code does not match with the description. The description used "John", but the code used "john", without the capitalisation.

image.png

nus-se-bot commented 1 year ago

Team's Response

Thanks for bringing this up! However, we feel that this is a very insignificant issue since we have mentioned in the Features part of our UG that parameters are case-insensitive (including KEYWORD for find), thus the capitalisation does not matter and "John" is equals to "john" in this context (note than john is not referring to the NAME parameter in n/NAME, which is case-sensitive).

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Hi, I strongly believe that this part requires more clarification for the readers because it is very confusing. Maybe you should change it to the same capitalisation for consistency, with can be important and make it less confusing to the readers, then add a note below to the readers that it is case insensitive. Because mentioned at the start, NAME and n/NAME can be quite similar.