yyyyyyyan / bandcamper

Bandcamp downloader
MIT License
44 stars 9 forks source link

Fix occasional `NoneType` exceptions and possible issue with `--no-fallback` argument #14

Closed Brisppy closed 9 months ago

Brisppy commented 9 months ago

Thanks for making this project it's really helpful for me when archiving artists.

8851f81aba441af7b548f323c30df6c44c7d6b26 - I was encountering NoneType errors mention in #5 - the issue was that sometimes when the response was interpreted as binary rather than text it would not contain the entire response. I wasn't able to dig into why this happened for only some albums but this seems to fix every case I came across.

4d759f62b2a48fec9aec9b9426694f070d0c0d8a - The other fix is with --no-fallback, I may be interpreting it wrong but my assumption is that while downloading an artists' page that it would skip over paid tracks and continue onto the next rather than erroring out completely - the raise could probably be remove completely but I wasn't sure if this was intentional or not.