yyyyyyyan / bandcamper

Bandcamp downloader
MIT License
44 stars 9 forks source link

TypeError: unsupported format string passed to NoneType.__format__ #7

Closed BuddhiLW closed 1 year ago

BuddhiLW commented 1 year ago

If you try out:

bandcamper -f flac  sonoorarecords

You will get this error for every track:

Traceback (most recent call last):
  File "/home/lw/.conda/bin/bandcamper", line 8, in <module>
    sys.exit(main())
  File "/home/lw/.conda/lib/python3.10/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/home/lw/.conda/lib/python3.10/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/home/lw/.conda/lib/python3.10/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/lw/.conda/lib/python3.10/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/home/lw/.conda/lib/python3.10/site-packages/bandcamper/__main__.py", line 169, in main
    bandcamp_downloader.download_all(destination, output, output_extra, *audio_formats)
  File "/home/lw/.conda/lib/python3.10/site-packages/bandcamper/bandcamper.py", line 351, in download_all
    self.download_from_url(
  File "/home/lw/.conda/lib/python3.10/site-packages/bandcamper/bandcamper.py", line 310, in download_from_url
    file_paths = self.download_fallback_mp3(
  File "/home/lw/.conda/lib/python3.10/site-packages/bandcamper/bandcamper.py", line 261, in download_fallback_mp
3
    f"{artist} - {album} - {track['track_num']:02d} {track['title']}{{ext}}",
TypeError: unsupported format string passed to NoneType.__format__

I tried doing catch, if etc to know if there's an artist, album , track and ext variables available, and in doing so, trying different formating (not using an usupported format with an empty variable).

But, my skills with python are not so great and I failed miserably.

I notice it's a pattern in many tries I had with the software.