search

yyyyyyyan / rockstar-py

Python transpiler for the esoteric language Rockstar
MIT License
95 stars 26 forks source link

Code refactoring #3

Closed deepserket closed 6 years ago

deepserket commented 6 years ago

why command line args are managed in 2 different files? it's basically the same code (obviously the version that use argparse is better)

jmsv commented 6 years ago

Using context managers is a good idea instead of opening and closing files :+1:

These changes still use sys.argv in rockstar.py - would it be better remove this in favor of the argparse solution? E.g.:

# rockstar.py
...
if __name__ == '__main__':
    command_line.main()
yyyyyyyan commented 6 years ago

Thanks for that! I'll accept the PR and change rockstar.py as suggested by @jmsv