yzcjtr / GeoNet

Code for GeoNet: Unsupervised Learning of Dense Depth, Optical Flow and Camera Pose (CVPR 2018)
MIT License
723 stars 181 forks source link

Fix missing declarations in geonet_main.py #29

Closed zacr0 closed 5 years ago

zacr0 commented 5 years ago

Added missing declarations for 'num_source', 'num_scales', 'add_posenet', 'add_dispnet' and 'add_flownet', which seems they must be declared before using them in newer Tensowflow versions.

Source: https://github.com/tinghuiz/SfMLearner/pull/70

yzcjtr commented 5 years ago

Hi @zacr0 , thanks for your PR. While I think these arguments should be derived instead of being set from input. Otherwise it might cause potential inappropriate configurations.