yzhang-gh / vscode-dic-completion

Dictionary completion
https://marketplace.visualstudio.com/items?itemName=yzhang.dictionary-completion
MIT License
52 stars 13 forks source link

Feature request: Move wordlist to configuration file enabling sync between devices #11

Closed jakobhviid closed 5 years ago

jakobhviid commented 5 years ago

Hello!

I would like to request moving the wordlist (custom words) to the VSCode configuration file as it would enable using sync applications (such as https://github.com/shanalikhan/code-settings-sync) to sync your custom words between devices.

Moving to the configuration file would also allow for project specific words, or editor wide words.

Current implementation of a wordlist could stay, and allow importing words from both sources as an option, as to not break compatibility with previous implementation.

This is literally the biggest problem for me as i move between many devices, and i use time syncing the wordlist.

Thanks for making this great extension!

yzhang-gh commented 5 years ago

As far as I know, you seem to be able sync custom files with settings here (supportedFileExtensions, I haven't tested).

jakobhviid commented 5 years ago

Hi.

Thank you very much for the suggestion. I have tried several times, but without luck. I think the problem relates to the fact i am using multiple operating systems. I use windows, mac and sometimes linux too. So, i am back here hoping for the option to keep words in a settings list.

Also, enabling custom words in settings would allow multiple users to sync their words for a project to the other developers of a project too, as a user has the "workspace" settings, and "editor" settings.

Thank you for your time.

yzhang-gh commented 5 years ago

Sorry I didn't remember the right link last time. It should be Custom Sync. (I have used it to sync my custom spell checker wordlist)

But I am willing to get it a try to make use of the user settings tonight. Get back to you later.

jakobhviid commented 5 years ago

Thank you! I found the correct link, don't worry.

yzhang-gh commented 5 years ago

Could you help test the dev build? There are two new options useExternalUserDictFile and userDictionary.

jakobhviid commented 5 years ago

Sure!.

I have tested the extension by adding the following to the settings file:

{
    "dictCompletion.userDictionary": [
        "qwertyuiop",
        "asdfghjklæø"
    ],
    "dictCompletion.UseExternalUserDictFile": false
}

I also tested it in the /.vscode/settings.json file, as well on windows and a mac. Everything seems to work as expected!

Thank you for taking the time to implement this feature!

yzhang-gh commented 5 years ago

Oops, the setting name should have been useExternalUserDictFile 😂. I'll change it and publish a new version.