yzhang-gh / vscode-dic-completion

Dictionary completion
https://marketplace.visualstudio.com/items?itemName=yzhang.dictionary-completion
MIT License
52 stars 13 forks source link

README/ Installation Instructions #54

Open brandtryan opened 3 months ago

brandtryan commented 3 months ago

When trying to follow directions to ensure ...

"[Markdown]": {
"editor.quickSuggestions": true
}

...VSCode complained and indicated it expected an Object (like you show for editor.quickSuggestions). You might update documentation to reflect this?

image

FYI: this is my first contribution to an open-source project! If I'm supposed to just fix the documentation and then submit a pull-request, please let me know!

yzhang-gh commented 3 months ago

It might be VS Code deprecated the old-style configuration since a certain release. We need to check what it is expecting now as there may be new fields other than other, comments and strings. PRs are always welcome 😉.