yzhang-gh / vscode-markdown

Markdown All in One
https://marketplace.visualstudio.com/items?itemName=yzhang.markdown-all-in-one
MIT License
2.93k stars 325 forks source link

GFM alerts don't look as good as expected when exporting HTML #1405

Closed mlaidouni closed 8 months ago

mlaidouni commented 8 months ago

What's the problem

The icons and text are no longer aligned (it seems to me that it worked fine until now). Is it possible to do this?

What's the expected result

How to reproduce

By writting this:

> [!NOTE]
> Useful information that users should know, even when skimming content.

> [!TIP]
> Helpful advice for doing things better or more easily.

> [!WARNING]
> Urgent info that needs immediate user attention to avoid problems.

> [!IMPORTANT]
> Key information users need to know to achieve their goal.

> [!CAUTION]
> Advises about risks or negative outcomes of certain actions.

Other information

Thanks for all ❤️

yzhang-gh commented 8 months ago

Thanks for the feedback. However, it looks alright on my machine. Could you try to install the latest dev build? Or it may be caused by your browser.

image

mlaidouni commented 8 months ago

Could you try to install the latest dev build?

I've just installed it but the result is the same.

Or it may be caused by your browser.

Which browser ?

yzhang-gh commented 8 months ago

Where did you open the exported HTML (e.g., Chrome)? You can also upload it to the GitHub comment (need to zip it first) and then I can see how it looks on my machine.

mlaidouni commented 8 months ago

After some tries, I found the source of the problem. It's the extension Markdown Preview Github Styling.

Result on Chrome with Markdown Preview Github Styling

screenshot 1

Result on Chrome without Markdown Preview Github Styling

screenshot 2

Other

Another question, is it possible to force all lines to end with two spaces , so that the line break is the same as on github?

yzhang-gh commented 8 months ago

Thanks for the update.

Another question, is it possible to force all lines to end with two spaces , so that the line break is the same as on github?

You need to set markdown.preview.breaks to true.