Apply MST when evaluating or predicting?

yzhangcs / parser

:rocket: State-of-the-art parsers for natural language.

https://parser.yzhang.site/

MIT License

829 stars 141 forks source link

Apply MST when evaluating or predicting? #6

Closed tysonyuu closed 5 years ago

tysonyuu commented 5 years ago

Hi, I found that it seems that you didn't apply MST when evaluating or predicting. In parser/model.py, the decoding function directly uses Argmax function instead of MST algorithm. It means that it will yield illegal dependency parsing result when predicting. Am I correct? Thank you

yzhangcs commented 5 years ago

Yes, the MST algorithm has not been implemented yet

tysonyuu commented 5 years ago

OK, thank you for your reply.