search

yzhao062 / combo

(AAAI' 20) A Python Toolbox for Machine Learning Model Combination
https://pycombo.readthedocs.io
BSD 2-Clause "Simplified" License
642 stars 106 forks source link

combo.models.score_comb.median() doesn't work properly with pd.DataFrame's #14

Open aks43725 opened 2 years ago

aks43725 commented 2 years ago

combo.models.score_comb.median() only work properly with pd.DataFrame as input X, which seems to compute the medians over columns rather than rows (as axis=1 works differently for np.ndarray and pd.DataFrame).

As far as I know, average() and maximization() don't have such problem, but I haven't tried aom() nor moa() yet.

yzhao062 commented 2 years ago

that was weired since basically all these methods are calling some operation with axis 1 using np return np.mean(scores, axis=1).ravel()

aks43725 commented 2 years ago

That's what I thought as well, but somehow I got some weird results earlier. I'll see if I can reproduce the weird results (which should be provided with the issue posting... sorry about that).

On Tue, Mar 8, 2022, 17:28 Yue Zhao @.***> wrote:

that was weired since basically all these methods are calling some operation with axis 1 using np return np.mean(scores, axis=1).ravel()

— Reply to this email directly, view it on GitHub https://github.com/yzhao062/combo/issues/14#issuecomment-1062283676, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGXFARI22VWFVACRUIHRBI3U67IADANCNFSM5QG7BTRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>