search

yzhao062 / pyod

A Python Library for Outlier and Anomaly Detection, Integrating Classical and Deep Learning Techniques
http://pyod.readthedocs.io
BSD 2-Clause "Simplified" License
8.27k stars 1.35k forks source link

issues about scikit-learn #542

Closed celestinoxp closed 4 months ago

celestinoxp commented 5 months ago

1- in requirements.txt you have "scikitlearn" i think should scikit-learn. should change underscore "" to hiffen "-". 2 - pyod is a indepencence of pycaret, i'm tryng making support to scikit-learn 1.4, but pyod have a conflict, please make support to scikit-learn 1.4 and release a new version

thanks

celestinoxp commented 5 months ago

@yzhao062

yzhao062 commented 5 months ago

Thanks for pointing this out. wiredly I did not notice this for six years and it is still working.

Some recent updates are made to pyod 1.1.3 to make it compatible with scikit-learn 1.4 -- all the tests are now passed with scikit-learn 1.4 (https://github.com/yzhao062/pyod/actions)

celestinoxp commented 4 months ago

Thanks for pointing this out. wiredly I did not notice this for six years and it is still working.

Some recent updates are made to pyod 1.1.3 to make it compatible with scikit-learn 1.4 -- all the tests are now passed with scikit-learn 1.4 (https://github.com/yzhao062/pyod/actions)

thanks for the new version. I honestly don't know why there was no error when using underscore instead of hyffen... strange... Interestingly I discovered some errors in my pycaret pr, so now it seems that everything has improved... thank you