yznts / kyoto

Asynchronous frontends with Go
https://pkg.go.dev/github.com/yznts/kyoto/v3
MIT License
651 stars 28 forks source link

Changed from QueryEscape to standard base64 encoding #55

Closed OpenSauce closed 2 years ago

OpenSauce commented 2 years ago

Closes #48

Not sure if this is what you were looking for or not, but seemed possible :)

yznts commented 2 years ago

Awesome! Thank you very much! The only thing is left - modify communication layer part. I'm not sure that I can contribute to this PR directly as far as it's from forked repo, so I'll need your help.

We have 2 functions that using state on client side. You can find that places here:

After modifications, you can build communication layer with running npm run build in static folder (don't forget to npm install before that). This will generate payload and will rewrite ext.ssa.client.go file.
For testing, you can go to the .demo folder, run with go run . and check all Actions on the page (especially calculation demo and form demo). Anyway, you can just push update here and I'll check it :)

OpenSauce commented 2 years ago

@yuriizinets I'll take a look now, I'm happy to try contribute and learn a bit more about the project. Seems an interesting concept.

Just for future reference, you can actually add commits to this PR :) There's an option: image

OpenSauce commented 2 years ago

@yuriizinets check now, maybe I did it wrong :) But the information on the .demo and the payload was really helpful.

yznts commented 2 years ago

Seems to be OK :) Thank you very much for contribution!