yzslab / gaussian-splatting-lightning

A 3D Gaussian Splatting framework with various derived algorithms and an interactive web viewer
Other
457 stars 38 forks source link

Bug in the code #10

Closed KaziiBotashev closed 10 months ago

KaziiBotashev commented 10 months ago

Hey! Thank you for an awesome viewer and implementation!

There is a bug in the code in the fx, fy computing from saved trajectory in rendering.

Line 61 in render.py should be using tangent function not arctangent one:

fx = width / (2 * torch.tan(fov / 2))

yzslab commented 10 months ago

You are right, thanks!