yzslab / gaussian-splatting-lightning

A 3D Gaussian Splatting framework with various derived algorithms and an interactive web viewer
Other
457 stars 38 forks source link

Updates for utils/fuse_appearance_embeddings_into_shs_dc #46

Closed hardikdava closed 1 month ago

hardikdava commented 1 month ago

@yzslab I have fixed few things in this script.

hardikdava commented 1 month ago

@yzslab Right now, it is loading all the data to cpu/gpu. The script did not work on laptop gpu. I had to use bigger machine to work with large dataset. Can you suggest how can I make it lazy image loading for this script. I suggest as following.

yzslab commented 1 month ago

@yzslab Right now, it is loading all the data to cpu/gpu. The script did not work on laptop gpu. I had to use bigger machine to work with large dataset. Can you suggest how can I make it lazy image loading for this script. I suggest as following.

  • making lazy dataset loading
  • make prunning optional

Hi, this script only load cameras into GPU, and this will not consume too much GPU memory. Though pruning is optional, calculating the visibilities is required by weighted fusing, so you must use a machine equipped with a NVIDIA GPU.

To reduce GPU memory consumption:

yzslab commented 1 month ago

@hardikdava Hi, take a look the reveiw comment of internal/utils/gaussian_utils.py above.

yzslab commented 1 month ago

Hi, I have made a modification to your internal/utils/gaussian_utils.py. Check whether it works.

yzslab commented 1 month ago

@hardikdava Hi, take a look the reveiw comment of internal/utils/gaussian_utils.py above.

Sorry, I found I forgot to submit the review yesterday.

hardikdava commented 1 month ago

@yzslab sorry for late reply. Added my comments to your questions.

yzslab commented 1 month ago

Thanks!