yzyhk904 / hifi-maximizer-mod

A Magisk module for maximizing the digital audio fidelity by reducing jitters on audio outputs (USB DACs, Bluetooth a2dp, DLNA, etc.)
GNU Affero General Public License v3.0
112 stars 6 forks source link

Not Compatible With Apatch! #14

Closed Lynxs16 closed 5 months ago

Lynxs16 commented 6 months ago

Not working on Apatch! Install_2024-03-30T07_08_02.146780.log

yzyhk904 commented 6 months ago

I wouldn't support incompatible Magisk variants. Please use Official Magisk!

If you like try Compatible Magisk-mirroring. This may give you a help.

Lynxs16 commented 6 months ago

Apatch is not a Magisk variant. its a totally different root method and i did try this module and unfortunately this doesn't work.

On Sat, Mar 30, 2024 at 11:08 AM yzyhk904 @.***> wrote:

I wouldn't support incompatible Magisk variants. Please use Official Magisk!

If you like try Compatible Magisk-mirroring https://github.com/yzyhk904/compatible-magisk-mirroring. This may give you a help.

— Reply to this email directly, view it on GitHub https://github.com/yzyhk904/hifi-maximizer-mod/issues/14#issuecomment-2027928395, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBJY4WNY7R2ZF3FOJ36FUY3Y2ZFVPAVCNFSM6AAAAABFPEO5QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHEZDQMZZGU . You are receiving this because you authored the thread.Message ID: @.***>

yzyhk904 commented 6 months ago

If you are right, this module is for Magisk and nothing to do with Apatch. Don't try to install this module on Apatch.

yzyhk904 commented 5 months ago

I updated Compatible Magiks-mirroring. This should work on APatch now, but you need some extra editing for Hifi maximizer module ZIP file (see README in details).

Lynxs16 commented 5 months ago

Thanks, I'll check it out!

On Wed, Apr 3, 2024 at 5:26 PM yzyhk904 @.***> wrote:

I updated Compatible Magiks-mirroring https://github.com/Magisk-Modules-Alt-Repo/compatible-magisk-mirroring. This should work on APatch now, but you need some extra editing for Hifi maximizer module ZIP file (see README in details).

— Reply to this email directly, view it on GitHub https://github.com/yzyhk904/hifi-maximizer-mod/issues/14#issuecomment-2034380952, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBJY4WMGFZS4FCPQF66DTU3Y3PU7FAVCNFSM6AAAAABFPEO5QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZUGM4DAOJVGI . You are receiving this because you authored the thread.Message ID: @.***>

Lynxs16 commented 5 months ago

[image: Screenshot_20240405-114151.jpg][image: Screenshot_20240405-114203.jpg][image: Screenshot_20240405-114217.jpg] It still doesn't work! I am using Apatch Ver 10657 which is the latest and after flashing the magisk mirroring it is still giving me same error. i have attached the installation log for hifi maximizer module if you want to take a look at it and let me know if you need help testing it.

On Wed, Apr 3, 2024 at 5:26 PM yzyhk904 @.***> wrote:

I updated Compatible Magiks-mirroring https://github.com/Magisk-Modules-Alt-Repo/compatible-magisk-mirroring. This should work on APatch now, but you need some extra editing for Hifi maximizer module ZIP file (see README in details).

— Reply to this email directly, view it on GitHub https://github.com/yzyhk904/hifi-maximizer-mod/issues/14#issuecomment-2034380952, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBJY4WMGFZS4FCPQF66DTU3Y3PU7FAVCNFSM6AAAAABFPEO5QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZUGM4DAOJVGI . You are receiving this because you authored the thread.Message ID: @.***>

yzyhk904 commented 5 months ago

I wrote extra editing was needed! Read README!

Lynxs16 commented 5 months ago

Sorry I didn't understood what I have to do the instructions are not clear to me as I am a donut can you please simplify the instructions?

On Fri, Apr 5, 2024, 8:38 PM yzyhk904 @.***> wrote:

I wrote extra editing was needed! Read README!

— Reply to this email directly, view it on GitHub https://github.com/yzyhk904/hifi-maximizer-mod/issues/14#issuecomment-2040047174, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBJY4WPLW3P3JQJDUOC2GVTY325AXAVCNFSM6AAAAABFPEO5QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGA2DOMJXGQ . You are receiving this because you authored the thread.Message ID: @.***>

yzyhk904 commented 5 months ago

Did you read README? It's very simple. Replace every "magisk --path" with "ksu-magisk --path" in the ZIP file. OR use official Magisk instead of APatch.

Lynxs16 commented 5 months ago

yeah i did read README and i will try it

On Fri, Apr 5, 2024 at 10:15 PM yzyhk904 @.***> wrote:

Did you read README? It's very simple. Replace every "magisk --path" with "ksu-magisk --path" in the ZIP file. OR use official Magisk instead of APatch.

— Reply to this email directly, view it on GitHub https://github.com/yzyhk904/hifi-maximizer-mod/issues/14#issuecomment-2040243089, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBJY4WP3MTMQNDMIDRAM4LTY33IJLAVCNFSM6AAAAABFPEO5QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGI2DGMBYHE . You are receiving this because you authored the thread.Message ID: @.***>

Lynxs16 commented 5 months ago

Hey I did manage to get the modules installed and i installed hifi maximizer usb sample rate unlocker and audio jitter silencer. The audio jitter silencer didn't require any editing though. After flashing i tested a lossless song on apple music and everything worked fine and when i tried an high res lossless song it played fine for like 10-15 sec and then it started stuttering like crazy. I thought some other module might be interfering so I uninstalled all modules I thought could interfere but nothing worked. It still stuttered. Also, for some reason the flashlight option was completely disabled i couldn't turn on the flash light after I flashed the hifi maximizer module.

For Additional info I use apple music without any wavelet or dolby atmos sound enhancement sort of application and i use the Abigail pro dongle dac with the kz edx pro iems paired

On Fri, Apr 5, 2024 at 11:46 PM Suraj Singh @.***> wrote:

yeah i did read README and i will try it

On Fri, Apr 5, 2024 at 10:15 PM yzyhk904 @.***> wrote:

Did you read README? It's very simple. Replace every "magisk --path" with "ksu-magisk --path" in the ZIP file. OR use official Magisk instead of APatch.

— Reply to this email directly, view it on GitHub https://github.com/yzyhk904/hifi-maximizer-mod/issues/14#issuecomment-2040243089, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBJY4WP3MTMQNDMIDRAM4LTY33IJLAVCNFSM6AAAAABFPEO5QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGI2DGMBYHE . You are receiving this because you authored the thread.Message ID: @.***>

yzyhk904 commented 5 months ago

Read README carefully again!

As I wouldn't support APatch and you edited the module, its's yours, not mine. Resolve problems by yourself.