z------------- / CPod

(UNMAINTAINED) A simple, beautiful podcast app for Windows, macOS, and Linux.
Apache License 2.0
746 stars 76 forks source link

TypeError when Cancel is clicked in Downloads directory browser #149

Closed eralpsahin closed 5 years ago

eralpsahin commented 5 years ago

CPod version: v1.27.1 and master branch

Platform: Mac

Install type (.deb, Snap, etc.):.app and development install on Mac

Description: Clicking on Cancel button in Downloads Directory Browser creates an uncaught error because Electron dialog returns filePaths and it is undefined when Cancel is clicked according to the documentation. Variable is not checked if it is undefined or not.

Steps to reproduce:

  1. Settings
  2. Click on Browse under Downloads section
  3. Click Cancel in the opened browser.

Expected Result: Nothing should happen.

Actual Result: Uncaught TypeError: Cannot read property '0' of undefined because there is no check.