z------------- / CPod

(UNMAINTAINED) A simple, beautiful podcast app for Windows, macOS, and Linux.
Apache License 2.0
746 stars 76 forks source link

Queue function not working #234

Open Mpkch opened 3 years ago

Mpkch commented 3 years ago

CPod version: 1.28.0 Platform: Windows 10 Installation type (.deb, Snap, etc.): CPod-Setup-1.28.0.exe

Description: Queue function doesn't work - popup appears to say that episode is queued, but Queue remains empty

cbus-ui.js:920 Uncaught TypeError: Cannot read property 'fromUI' of undefined
    at Object.callback (cbus-ui.js:920)
    at Object.cbus.broadcast.send (cbus-broadcast.js:8)
    at Object.enqueue (cbus-audio.js:279)
    at HTMLButtonElement.elem.getElementsByClassName.onclick (cbus-ui.js:620)

(anonymous) @ cbus-ui.js:920
cbus.broadcast.send @ cbus-broadcast.js:8
enqueue @ cbus-audio.js:279
elem.getElementsByClassName.onclick @ cbus-ui.js:620

Version of CPod which introduced the issue (if applicable):

Steps to reproduce: Select any podcast episode and click on the Add To Queue icon. The "added 'episode name' to Queue popup appears as intended, but error above is thrown in the console. Queue is empty

Other information (e.g. Developer Tools console log, screenshots) if possible:

kadykov commented 2 years ago

I have the same issue on Windows 10 x64

leighsmith commented 2 years ago

The problem is the queueUpdate message is sent from both cbus-ui.js and cbus-audio.js, and is listened to by cbus-ui.js, cbus-audio.js and cbus-data.js, but only within cbus-ui.js is there a {fromUI: true} data field passed, the remainder of the .send(queueUpdate) statements do not pass a data field, which causes the error message.

leighsmith commented 2 years ago

The easy fix is to simply add {fromUI: false} to all of the statements with .send("queueUpdate"), but it's not clear if indeed that fromUI should be declared as false, or true in which cases?

leighsmith commented 2 years ago

OK there is a fix on my branch but it's really just a one line change.

Desconvidado commented 2 years ago

same issue here, im using linux appimage.

Xunius commented 2 years ago

Hi, are we expecting a new release any time soon. I also got the queue issue from Linux AppImage release.

pessimal commented 1 year ago

Hi, are we expecting a new release any time soon. I also got the queue issue from Linux AppImage release.

Bump for anniversary