search

z------------- / CPod

(UNMAINTAINED) A simple, beautiful podcast app for Windows, macOS, and Linux.
Apache License 2.0
746 stars 76 forks source link

Global media controls in KDE #34

Open albaphysic opened 6 years ago

albaphysic commented 6 years ago

Would it be possible to make cpod controllable with KDE's built in media player controls? I'm mainly interested in play/pause controls.

I believe it's handled by mpris?

image

image

z------------- commented 6 years ago

If it is handled by MPRIS then this issue should be resolved along with #28. I'll ping here when that one's resolved so we can see if that's the case.

albaphysic commented 6 years ago

Oh sorry. I've actually seen that post before but didn't know what mpris was at the time, just learned what it is while making this post. Didn't put 2 and 2 together.

From my quick googling it seems like that's what it is in KDE so fingers crossed.

z------------- commented 6 years ago

Hello, MPRIS is indeed responsible for KDE global media controls. (Pre)release 1.20.0 contains basic MPRIS integration including but not limited to play and pause. Tested on KDE neon. Please let me know if there are any problems.

albaphysic commented 6 years ago

Hi, thanks for implementing it :)

Looks like it's working in the system tray which is great, but it doesn't work in the task manager panel right click context menu. Perhaps there's some extra implementation required to get it to work there? If you don't know how, I can try to find out in some kde forums how that's handled and let you know.

Here's CPod media controls working in the system tray :+1: : image

Here's how media controls in the task manager panel working for Spotify looks like: image

Here's how it looks for CPod: image

z------------- commented 6 years ago

It might be the case that Spotify's context menu controls are not set by KDE's MPRIS integration but a set of buttons specified in its desktop file. I'll look into how I can achieve this in Electron (the framework that CPod uses).

albaphysic commented 6 years ago

Other apps that I noticed have it are VLC, Rhythmbox, and Clementine, though they're not Electron.

I installed a few Electron music apps from this list https://electronjs.org/apps?category=music to see if any developers managed to do it, but none of the apps I tried had it, (though none had general MPRIS support in the system tray either). I'll try some more later.

z------------- commented 6 years ago

I couldn't find anything in the documentation for Electron related to customizing the taskbar context menu, so I'll have to find a way to get around that by modifying the desktop entry. There's a possible solution that I'm already working on and I'll let you know how that goes. Thanks.

albaphysic commented 6 years ago

:+1: :+1: :+1: