search

z-classic / z-nomp

z-nomp is mining pool software for Zcash and Zclassic so you can create internet money in your home!
MIT License
287 stars 441 forks source link

Major Updates 2 #109

Closed hellcatz closed 7 years ago

hellcatz commented 7 years ago

major: added support for komodo, zcash, zclassic, (zdash not tested) coins: added requireShielding boolean coins: updated zcash_testnet founders addresses configs: added komodo_example.conf api.js: added payments json api call stats.js: improved getTotalSharesByAdress to support multiple coins. stats.js: report more collected stats stats.js: report payment stats stats.js: optimizations to historical data saving paymentProcessor.js: added requireShielding support paymentProcessor.js: added support to pay directly from komodo pool address without shielding first paymentProcessor.js: lower tx fee reserve for komodo to 0.00005 KMD paymentProcessor.js: tx fee reserve for all coins is 0.0004 paymentProcessor.js: improved multi-coin support paymentProcessor.js: added minConfShield and minConfPayout variables paymentProcessor.js: updated coin network stat caching paymentProcessor.js: improved operation id handling when shielding coins paymentProcessor.js: updated coin network stat caching paymentProcessor.js: updated payment stat collection in redis miner_stats.html: removed ZEC references

hellcatz commented 7 years ago

Note, this is a semi breaking change. I changed the payments in redis to scoring for good reasons ;) You must delete previous hash (not scoring) payments under coins in redis.

See Screenshot below: image

WaveringAna commented 7 years ago

Reviewing

sonicdx10 commented 7 years ago

Zdash team is going to update code (.5 or +) , maybe it can fix the user-stats-rpc issue

WaveringAna commented 7 years ago

I think instead of going nuclear with payments, just report null for old ones

hellcatz commented 7 years ago

We'll need to specifically test if this can be accomplished (backwards compatible). If no one else can, I may have time this weekend.

sennevb commented 7 years ago

Does this one fix the issue that komodo cant be used together with zcash??

sonicdx10 commented 7 years ago

That... it's already fixed on actual branch

sennevb commented 7 years ago

okay thanks, will test this out then..

sennevb commented 7 years ago

still getting this error when i enabled komodo:

still got this error:

/root/pool/node_modules/typeforce/index.js:154 throw tfSubError(e, i) ^ Error: Expected property "1" of type Satoshi, got Number NaN

sonicdx10 commented 7 years ago

You should check closed issues just because it is a repeated issue already fixed

it's all about blocktemplate

hellcatz commented 7 years ago

There is issues with the payment processor in z-nomp when running komodo that this PR resolves. I'm am almost done testing the redis database concerns mentioned above. Preliminary results look perfect.

hellcatz commented 7 years ago

Redis does not have issue storing new format with old format. image

New JSON API payments output ../api/payments JSON output is valid with both formats. image

From my testing on zcash_testnet, there is no issues with redis. This is not a breaking change as I originally assumed 👍

sennevb commented 7 years ago

merge merge ;-)