search

z-classic / z-nomp

z-nomp is mining pool software for Zcash and Zclassic so you can create internet money in your home!
MIT License
287 stars 441 forks source link

website files may not be reloading #118

Closed hellcatz closed 7 years ago

hellcatz commented 7 years ago 
(node:2363) DeprecationWarning: (node-watch) First param in callback function  is replaced with event name since 0.5.0, use  `(evt, filename) => {}` if you want to get the filename

node-watch used to reload website files is may not be working with latest npm package updates https://github.com/z-classic/z-nomp/blob/master/libs/website.js#L98-L106

sennevb commented 7 years ago

i noticed this also, you need to restart pool to see changes on frontend

WaveringAna commented 7 years ago

Sigh, JavaScript. Always breaking old code with updates

hellcatz commented 7 years ago

Below is a solution to the issue. It requires node-watch 0.5.0 +...

yuanchuan commented 7 years ago

Sorry for the breaking.

I suggest replacing all the "*" in package.json with prefixed tilde(~) or caret(^) version numbers to prevent something like this to happen again. (see https://docs.npmjs.com/files/package.json)

Some tools might be helpful:

https://yarnpkg.com/en/ https://docs.npmjs.com/cli/shrinkwrap

WaveringAna commented 7 years ago

It's fine, I made a PR to lockdown package versions #122