search

z-classic / zclassic

Zclassic is financial freedom. ZK-SNARKs, and no founder's fee.
https://www.reddit.com/r/Zclassic/
Other
189 stars 81 forks source link

Significant updates enabling explorer, includes mempool and address indexing methods #169

Closed ch4ot1c closed 6 years ago

ch4ot1c commented 6 years ago

This code needed to be migrated from Zcash 1.0.13 in order to index versions of Zclassic past 1.0.4. By 'explorers', we mean Insight-UI and Insight-API (from johandjoz/insight-ui-zclassic)

RhettCreighton commented 6 years ago

Anyone care to review this?

ch4ot1c commented 6 years ago

In BTCP, we've used it as a separate branch and an analogous release ('indexing-enabled'); kept unmerged.

ch4ot1c commented 6 years ago

seem to be more future-proof approaches, per the discussion here: https://github.com/bitcoin/bitcoin/pull/10370

nimbosa commented 6 years ago

Hi all, looks like @TheTrunk just contributed a cleaner implementation here: https://github.com/z-classic/zclassic/pull/182.

It will be a few days before I can properly check it out and maybe compare the two?

nimbosa commented 6 years ago

@ch4ot1c one question, do you know what was the motivation behind the change in file permissions to make them all executable? was it deliberate / necessary?

nimbosa commented 6 years ago

keep separate for now