search

z-classic / zclassic

Zclassic is financial freedom. ZK-SNARKs, and no founder's fee.
https://www.reddit.com/r/Zclassic/
Other
189 stars 81 forks source link

Bitcore integration #182

Closed TheTrunk closed 5 years ago

TheTrunk commented 5 years ago

This is a proper Bitcore integration into zclassic codebase.

TheTrunk commented 5 years ago

Ouch I just noticed that there already is a PR for this. Whups. At least this one is cleaner and does not change file permissions

nimbosa commented 5 years ago

Hi, thanks for this contribution @TheTrunk, is this based on updated bitcore patches here https://github.com/bitcoin/bitcoin/pull/10370?

TheTrunk commented 5 years ago

Hi, It is the same integration as is for example in zelcash, hush, zcash which is based on the original bitcore integration by satoshilabs(?). It is possible that the referenced PR on bitcoin contains some additional patches but since its a different codebase it is a bit hard to compere. I believe bitcoin actually uses bcoin in their insight explorers. This integration is present in a daemon which powers following zclassic explorer: https://explorer.zcl.zeltrez.io .

nimbosa commented 5 years ago

Uhmm.. Alright, do you have a link to the original source of this particular implementation? I will be checking this and the older PR, and maybe we will need to rebase some changes as we are merging PRs roughly in chronological order. Right now, the earlier implementation lives on a completely separate branch and using a separate build. I am looking into unifying them if possible and convenient.

Again, many thanks @TheTrunk. :)

nimbosa commented 5 years ago

keep on separate branch for now: https://github.com/z-classic/zclassic/tree/improvement/explorer