Sending album art as icon instead of app icon - Githubissues

z-huang / InnerTune

A Material 3 YouTube Music client for Android

GNU General Public License v3.0

3.71k stars 221 forks source link

Sending album art as icon instead of app icon #1166

Open ThatOneCalculator opened 7 months ago

ThatOneCalculator commented 7 months ago

Checklist

[ ] I am able to reproduce the bug with the latest debug version.
[X] I've checked that there is no open or closed issue about this bug.
[X] This issue contains only one bug.
[X] The title of this issue accurately describes the bug.

Steps to reproduce the bug

Apparently, this issue: https://github.com/KieronQuinn/Smartspacer/issues/77#issuecomment-1849023887 is caused by InnerTune sending its app icon as the album art of the current song instead of the InnerTune logo

Expected behavior

Widgets accessing InnerTune's icon should have the InnerTune icon

Actual behavior

Screenshot_20231210-090604~2

InnerTune version

0.5.3

Android version

Android 14

KieronQuinn commented 7 months ago

For clarity, Smartspacer was using METADATA_KEY_DISPLAY_ICON, which for your app appears to be providing either the album art or a fully solid icon (which is broken when tinting). This field should be an icon, not art.

This app is far from the only one to do this though, so Smartspacer no longer uses the field.